I have a setup.cfg file with the following configuration:
[isort] force_alphabetical_sort = True force_single_line = True lines_after_imports = 2 line_length = 200 not_skip = __init__.py
I have a file with the following imports:
from plone.app.testing import applyProfile from plone.app.testing import FunctionalTesting
The import order is correct, but flake8-isort 2.1.2 indicates the error:
I001 isort found an import in the wrong position
@idgserpro if you run isort it does not complain right? On the meantime you can stick with 2.0.x releases until we fix it in 2.1.3.
@cas— does it ring a bell?
It’s along the same lines as wrapped imports, it’s rather annoying that isort in_lines doesn’t match out_lines, so it strictly is an isort bug but it’s easy to modify the existing wrapped lines fix:
On line 176 removing the space in if 'n ' in line: so it becomes if 'n' in line: should solve this.
I didn’t expect a wrapped line without indenting so I shall switch to using splitlines() instead…
Using the incorrectly_sorted attribute would be helpful but that has a bug when False there still can be whitespace changes to the imports.
@gforcada when I run isort:
it leaves in the correct order.
gforcada
added a commit
that referenced
this issue
Nov 25, 2016
Fix #23: Invalid warnings with force_single_line enabled
@idgserpro would you mind giving a try to 2.1.3? I just released it with #23 on it.
hvelarde
added a commit
to simplesconsultoria/collective.publishthis
that referenced
this issue
Nov 25, 2016
Hello, I am getting this error running isort 2.2.1, python 3.6.0, and tox 2.7.0. I am running it within tox as well as with the default config.
The error indicates the first 2 lines are in the wrong position or I001:
from selenium.common.exceptions import NoSuchElementException
from selenium.webdriver.common.by import By
from foxpuppet import expected
from foxpuppet.windows import BaseWindow
from foxpuppet.windows.browser.navbar import NavBar
from foxpuppet.windows.browser.notifications import BaseNotification
And it also says that there is an I004 isort found an unexpected blank line in imports for the blank line inbetween on line 3. However running isort directly on the file shows no errors. Any tips?
@jrbenny35 Please create a new issue, this one is closed!
How can I fix it?
Test error: flake8 isort found an import in the wrong position
from api.v1.filters import TitleFilter
from api.v1.permissions import (AuthorAdminModeratorOrReadOnly, IsAdmin,
IsAdminOrReadOnly)
from api.v1.serializers import (CategorySerializer, CommentSerializer,
ConfirmationCodeSerializer, GenreSerializer,
ReviewSerializer, SignUpSerializer,
TitleReadSerializer, TitleWriteSerializer,
UserEditSerializer, UserSerializer)
**from api_yamdb.settings import DEFAULT_FROM_EMAIL**
from django.contrib.auth.tokens import default_token_generator
from django.core.mail import send_mail
from django.db.models import Avg
from django.shortcuts import get_object_or_404
from django_filters.rest_framework import DjangoFilterBackend
from rest_framework import filters, permissions, status, viewsets
from rest_framework.decorators import action, api_view, permission_classes
from rest_framework.response import Response
from rest_framework_simplejwt.tokens import AccessToken
from reviews.models import Category, Genre, Review, Title, User
from .mixins import CreateDestroyViewSet```
I use isort . and isort views.py but there are no changes.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
Hi,
I’m using flake8-isort plugin in my projects and since isort released the new version, v5.0.0, the plugin stopped working.
Here is the log with traceback:
Traceback (most recent call last):
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 157, in load_plugin
self._load()
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 134, in _load
self._plugin = self.entry_point.load()
File "/app/.tox/lint/lib/python3.6/site-packages/importlib_metadata/__init__.py", line 105, in load
module = import_module(match.group('module'))
File "/usr/local/lib/python3.6/importlib/__init__.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 994, in _gcd_import
File "<frozen importlib._bootstrap>", line 971, in _find_and_load
File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/app/.tox/lint/lib/python3.6/site-packages/flake8_isort.py", line 3, in <module>
from isort import SortImports
ImportError: cannot import name 'SortImports'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/app/.tox/lint/bin/flake8", line 8, in <module>
sys.exit(main())
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/main/cli.py", line 22, in main
app.run(argv)
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/main/application.py", line 360, in run
self._run(argv)
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/main/application.py", line 347, in _run
self.initialize(argv)
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/main/application.py", line 328, in initialize
self.find_plugins(config_finder)
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/main/application.py", line 159, in find_plugins
self.check_plugins.load_plugins()
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 415, in load_plugins
plugins = list(self.manager.map(load_plugin))
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 302, in map
yield func(self.plugins[name], *args, **kwargs)
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 413, in load_plugin
return plugin.load_plugin()
File "/app/.tox/lint/lib/python3.6/site-packages/flake8/plugins/manager.py", line 164, in load_plugin
raise failed_to_load
flake8.exceptions.FailedToLoadPlugin: Flake8 failed to load plugin "I00" due to cannot import name 'SortImports'.
Use isort to check if the imports on your python files are sorted the way you expect.
Add an .isort.cfg to define how you want your imports sorted and run flake8 as you usually do.
See isort documentation for .isort.cfg available options.
Install
Install with pip:
$ pip install flake8-isort
Install with conda:
$ conda install -c conda-forge flake8-isort
Configuration
If using the select option from flake8 be sure to enable the I category as well, see below for the specific error codes reported by flake8-isort.
See flake8 —help for available flake8-isort options.
Error codes
|
Error code |
Description |
|---|---|
|
I001 |
isort found an import in the wrong position |
|
I002 |
no configuration found (.isort.cfg or [isort] in configs) |
|
I003 |
isort expected 1 blank line in imports, found 0 |
|
I004 |
isort found an unexpected blank line in imports |
|
I005 |
isort found an unexpected missing import |
Requirements
-
Python 3.7, 3.8, 3.9, 3.10, 3.11 and pypy3
-
flake8
-
isort
Relation to flake8-import-order
As an alternative to this flake8 plugin, there’s flake8-import-order that could be worth checking out. In contrast to this plugin that defers all logic to isort, the flake8-import-order comes bundled with it’s own logic.
flake8-import-order comes with a few predefined set of styles meanwhile this plugin can be customized a bit more. But the biggest difference could lie in that flake8-isort actually has the corresponding sorting engine isort that can sort the import orders of your existing python files. Meanwhile flake8-import-order has no such corresponding tool, hence big existing projects who want to adopt either would get a more automized experience choosing flake8-isort.
License
GPL 2.0
Changelog
6.0.0 (2022-12-22)
-
Drop isort 4.x support.
[gforcada] -
Add support for flake8 6.0.0.
[gforcada] -
Add –isort-no-skip-gitignore option to allow temporarily overriding the set
value of isort’s skip_gitignore option with False. This can cause
flake8-isort to run significantly faster at the cost of making flake8-isort’s
behavior differ slightly from the behavior of isort –check. [gschaffner]
5.0.3 (2022-11-20)
-
Fix broken add_options method, again. [casperdcl]
5.0.2 (2022-11-19)
-
Fix broken add_options method [casperdcl]
5.0.1 (2022-11-18)
-
Improve the config option is added and read back. [gforcada]
-
Bump plugin version. [gforcada]
5.0.0 (2022-10-08)
-
Update dependencies. [gforcada]
-
Revamp GitHub actions. [gforcada]
-
Drop python 3.6, and add python 3.10. [gforcada]
-
Use linters and formatters to keep code sane and beautiful. [gforcada]
4.2.0 (2022-08-04)
-
Fix compatibility with flake8 version 5. [nhymxu]
4.1.2.post0 (2022-07-25)
-
Release it as a wheel as well. [gforcada]
4.1.2 (2022-07-25)
-
The package no longer depends on testfixtures.
4.1.1 (2021-10-14)
-
Release py3 only wheels..
4.1.0 (2021-10-14)
-
Support flake8 4.x [g-as]
-
Switch from travis-ci to github actions. [g-as]
-
Drop python 2.7 support and 3.5 as well [g-as]
4.0.0 (2020-08-11)
-
Nothing changed yet.
4.0.0a0 (2020-08-07)
-
support isort >= 5 [bnavigator, pkolbus]
3.0.1 (2020-07-08)
-
Work around FailedToLoadPlugin exception by requiring isort 4.x. Likewise,
pin the major version of all dependencies, to reduce risk of any future
incompatibilities.
[pkolbus]
3.0.0 (2020-04-15)
-
Let isort search the configuration, rather than flake8-isort try to find it.
[jnns]
2.9.1 (2020-03-28)
-
Fix flake8 warning.
[sobolevn]
2.9.0 (2020-03-16)
-
Add python3.8 support.
[sobolevn]
2.8.0 (2019-12-05)
-
Look for isort configuration on .flake8 files as well.
[JohnHBrock] -
Document how to install flake8-isort on conda.
[marcelotrevisani] -
Look for isort configuration on pyproject.toml files as well.
[sanjioh]
2.7.0 (2019-03-19)
-
Improve the README.
[barbossa] -
Fix isort output when pipes are used.
[maerteijn]
2.6.0 (2018-12-01)
-
Use pytest to run tests.
[gforcada] -
New error code I005 isort foundan unexpected missing import.
[charettes] -
Add isort_show_traceback option to show verbose multi-line output
from isort, turned off by default
[sobolevn]
2.5 (2018-03-15)
-
Now requires isort >= 4.3.0.
[jleclanche]
2.4 (2018-02-25)
-
Fix input handling with flake8’s –stdin-display-name, and simplify it.
[blueyed] -
Remove flake8-polyfill dependency. flake8 >= 3.2.1 is required already, and
stdin is not read directly anymore.
[blueyed]
2.3 (2017-12-22)
-
Fix typo.
[paltman] -
Add tox.ini and .editorconfig to config search.
[cas–] -
Make this plugin compatible with flake8 hook.
As the hook copies the files out of tree,
flake8-isort never finds the correct configuration.
[jaysonsantos]
2.2.2 (2017-08-19)
-
Workaround for isort bug when skipping files.
[danpalmer]
2.2.1 (2017-05-12)
-
Release as universal wheel.
[gforcada]
2.2 (2017-03-26)
-
Support flake8 git hook.
[sergio-alonso] -
Support python 3.6.
[gforcada] -
Search configuration on home folder.
[gforcada]
2.1.3 (2016-11-25)
-
Fix yet another corner case.
[gforcada]
2.1.2 (2016-11-25)
-
Fix another corner case: ignored files.
[cas–]
2.1.1 (2016-11-25)
-
Fix corner cases of isort: newlines and grouped imports.
[cas–]
2.1.0 (2016-11-24)
-
Show the exact line and kind of error,
rather than a generic message.
[cas–]
2.0.3 (2016-11-22)
-
Update trove classifiers.
[gforcada]
2.0.2 (2016-11-22)
-
Add flake8 classifier.
[sigmavirus24] -
Require flake8 3.2.1.
flake8 series 3.1.x and 3.2.0 where not reporting flake8-isort errors.
[gforcada] -
Test on pypy and pypy3.
[gforcada] -
Fix tests and formatting.
[gforcada]
2.0.1 (2016-09-22)
-
Fix standard input processing.
[carljm]
2.0 (2016-09-14)
-
Refactor code to handle flake8 version 3.
[danpalmer] -
Require flake8 version 3.0.
[gforcada]
1.3 (2016-06-20)
-
Make error messages clearer.
[do3cc] -
Use either pep8 or pycodestyle (new name for pep8).
[Maxim Novikov] -
Fix coveralls.
[gforcada]
1.2 (2016-03-05)
-
Allow stdin processing, this way text editor can pass input to flake8.
[mjacksonw]
1.1.1 (2016-02-16)
-
Silence isort messages.
[gforcada] -
Improve wording.
[gforcada]
1.1 (2016-02-16)
-
Check for isort configuration on setup.cfg as well.
[plumdog]
1.0 (2015-12-16)
-
Check for an isort configuration file.
[gforcada]
0.2 (2015-09-14)
-
Fix entry point.
[gforcada]
0.1.post0 (2015-09-13)
-
Release wheels as well.
[gforcada]
0.1 (2015-09-13)
-
Initial release
[gforcada] -
Add all boilerplate files.
[gforcada] -
Create the flake8 plugin per se.
[gforcada]